-
Notifications
You must be signed in to change notification settings - Fork 268
feat(views): Add basic notification snippet #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add a basic notification snippet and associated files to the views module. Region-Tag: android_views_notifications_build_basic
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the snippet on this page: https://developer.android.com/develop/ui/views/notifications/build-notification
|
||
dependencies { | ||
|
||
implementation("androidx.core:core:1.13.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put these imports in the version catalog, like the other imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and fixed the merge conflicts in #640. It might be easier to resolve the code there.
Add a basic notification snippet and associated files to the views module.
Region-Tag: android_views_notifications_build_basic
Testing workflow for GitHub code migration.